fix(Select): retain selected options during remote searches #3926
+200
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
HaixingOoO,
NWYLZW,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
HaixingOoO
approved these changes
Oct 29, 2025
RylanBot
force-pushed
the
rylan/fix/select/search
branch
from
ad40198 to
7d7c91b
Compare
commit: |
Contributor
|
|
RylanBot
force-pushed
the
rylan/fix/select/search
branch
from
11c59cf to
27d6653
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Select component's remote search functionality by preserving selected options in the value-to-option mapping and triggering initial search on dropdown open. The changes enable the Select component to properly handle remote search scenarios where options are dynamically fetched.
- Preserves selected options in mapping to prevent state loss during remote searches
- Triggers search on dropdown open when search handler exists and input is empty
- Updates remote-search example to demonstrate both single and multiple select modes with loading states
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/select/hooks/useOptions.ts | Adds logic to merge previous selected options into the value-to-option mapping and exports helper function for value selection checking |
| packages/components/select/base/Select.tsx | Calls onSearch with empty string when dropdown opens for remote search initialization |
| packages/components/select/_example/remote-search.tsx | Rewrites example to showcase both single and multiple select with proper remote search implementation |
| test/snap/snapshots/ssr.test.jsx.snap | Updates SSR snapshot to reflect new example structure with Space component |
| test/snap/snapshots/csr.test.jsx.snap | Updates CSR snapshot to reflect new example structure with loading states |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(Select): 修复在选中选项后，输入框被清空但未触发对应的
onSearch回调问题fix(Select): 修复开启
onSearch与multiple时，选中选项丢失的问题本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单